Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vsphere name #339

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix vsphere name #339

merged 1 commit into from
Apr 8, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 8, 2019

Fixes a typo in vSphere name

NONE

@kron4eg
Fix vsphere name
3cd73f7 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 8, 2019
@kron4eg kron4eg requested a review from xmudrii April 8, 2019 14:17
@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2019
xmudrii
xmudrii approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64f68e7a59a3e89c65895097b3606ee0a651bd7d

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2019
@xmudrii
Copy link
Member

xmudrii commented Apr 8, 2019

/retest

4 similar comments
@xmudrii
Copy link
Member

xmudrii commented Apr 8, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 8, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Apr 8, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 8, 2019

/retest

@kubermatic-bot
Copy link
Contributor

@kron4eg: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 3cd73f7 link /test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0
pull-kubeone-e2e-digitalocean-conformance-1.13.5 3cd73f7 link /test pull-kubeone-e2e-digitalocean-conformance-1.13.5

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xmudrii
Copy link
Member

xmudrii commented Apr 8, 2019

As per DigitalOcean status page, there are API issues which are causing flakes. I'll retry testing once the issue is resolved.

@kron4eg
Copy link
Member Author

kron4eg commented Apr 8, 2019

as changes are not related to any of DO parts:

/override pull-kubeone-e2e-digitalocean-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-digitalocean-conformance-1.13.5, pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

In response to this:

as changes are not related to any of DO parts:

/override pull-kubeone-e2e-digitalocean-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 9fbf1ee into master Apr 8, 2019
@kubermatic-bot kubermatic-bot deleted the vsphere-names branch April 8, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii